Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INIReader.cpp #175

Closed
wants to merge 1 commit into from
Closed

Update INIReader.cpp #175

wants to merge 1 commit into from

Conversation

meiyasan
Copy link
Contributor

Update INIReader::INIReader prototype implementation to match header implementation.
This update is removing the warning when generating Doxygen documentation.

Update INIReader::INIReader prototype implementation to match header implementation.
@benhoyt
Copy link
Owner

benhoyt commented Jul 24, 2024

Thanks for the contribution, but I don't think I'll merge this. If we were going to change it here, we should change it everywhere and remove the using std::string line (but I'd rather not do that -- the using declaration is intentional as it keeps the code shorter). If Doxygen can't figure out that std::string and string (with using std::string) are the same thing, that's a Doxygen problem.

@benhoyt benhoyt closed this Jul 24, 2024
@meiyasan meiyasan deleted the patch-2 branch July 25, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants